Validate SignOptions fields against the DKIM2 specification #4

New issue

Closed

opened 2026-09-05 11:58:35 +00:00 by steve · 2 comments

steve commented

2026-09-05 11:58:35 +00:00

Owner

The signing API currently accepts values such as the nonce without validating them against the syntax required by the DKIM2 specification.

Is validation of these fields planned? If not, would you accept a PR that adds specification-compliant validation and returns an error for invalid values?

(from Raademar https://github.com/turscar/dkim2/issues/2)

The signing API currently accepts values such as the nonce without validating them against the syntax required by the DKIM2 specification. Is validation of these fields planned? If not, would you accept a PR that adds specification-compliant validation and returns an error for invalid values? (from Raademar https://github.com/turscar/dkim2/issues/2)

steve added the

enhancement

label

2026-09-05 11:58:35 +00:00

steve self-assigned this

2026-09-05 11:58:35 +00:00

steve commented

2026-09-05 17:04:00 +00:00

Author

Owner

Probably a good idea. We check parameters fairly thoroughly on mail we're validating, and it'd be nice to be more defensive against generating with bad parameters too.

👍 1

steve commented

2026-09-08 11:43:59 +00:00

Author

Owner

Fixed in 644f756bfb, with options.Validate.

Fixed in 644f756bfb, with options.Validate.

🎉 1

steve closed this issue

2026-09-08 11:43:59 +00:00